Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static code analysis _017 (The resource was not freed) #51

Closed
PawelModrzejewski opened this issue Dec 2, 2020 · 1 comment
Closed

Static code analysis _017 (The resource was not freed) #51

PawelModrzejewski opened this issue Dec 2, 2020 · 1 comment

Comments

@PawelModrzejewski
Copy link
Contributor

Short summary (details in attached file):

Event 29:  net_iface_l has gone out of scope and no longer references the resource of interest.
There are no remaining references to the resource new () from linux_hal_common.cpp:1040.

The resource was allocated at linux_hal_common.cpp:1040.
The last reference was lost at linux_hal_common.cpp:1044.
The resource was not freed.

gptp_017.txt
@PawelModrzejewski
Copy link
Contributor Author

This issue is fixed by PR #58

PawelModrzejewski added a commit to PawelModrzejewski/gptp that referenced this issue Dec 15, 2020
@PawelModrzejewski
linux_hal_common: the resources (sd_*) not freed (SCA _002/_003/_017 A…
e1f2a1b 
…vnu#38/Avnu#39/Avnu#51)

Static code analysis fix _002 _003 _017 (Issues Avnu#38 Avnu#39 Avnu#51)

Added sd_general and sd_event initalization in LinuxNetworkInterface()
constructor; now sockets can be properly closed in relevant destructor code,
which was not called at all in case of failures.
ifname initialization moved up to solve compilation error ("jump to label 'exit_error'
crosses initialization of 'InterfaceName* ifname")
@PawelModrzejewski PawelModrzejewski mentioned this issue Dec 15, 2020
Merged
avinash-palleti added a commit that referenced this issue Dec 16, 2020
@avinash-palleti
Merge pull request #58 from PawelModrzejewski/issue_38_39_sockets_not…
ad50785 
…_freed

linux_hal_common: the resources (sd_*) not freed (SCA _002/_003/_017 #38/#39/#51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PawelModrzejewski