Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old avrdude_message() can go away #1719

Closed
dl8dtl opened this issue Mar 18, 2024 · 3 comments · Fixed by #1730
Closed

Old avrdude_message() can go away #1719

dl8dtl opened this issue Mar 18, 2024 · 3 comments · Fixed by #1730
Labels
enhancement New feature or request

Comments

@dl8dtl
Copy link
Contributor

dl8dtl commented Mar 18, 2024

I just noticed that it's not used anymore anywhere.
@dl8dtl dl8dtl added the enhancement New feature or request label Mar 18, 2024
@stefanrueger
Copy link
Collaborator

Do you want the new avrdude_message2() be renamed to avrdude_message() once the old one is removed?

@mcuee
Copy link
Collaborator

mcuee commented Mar 27, 2024

Do you want the new avrdude_message2() be renamed to avrdude_message() once the old one is removed?

Hmm, I think it is better not to do that since it will cause confusion.

We can add a note in avrdude_message2() to mention that there was avrdude_message() function in the history but that was removed since it is no longer in use.

@stefanrueger stefanrueger mentioned this issue Mar 29, 2024
Merged
@dl8dtl
Copy link
Contributor Author

dl8dtl commented Mar 29, 2024

We can add a note in avrdude_message2() to mention that there was avrdude_message() function in the history but that was removed since it is no longer in use.

I did so on Stefan's PR.

dl8dtl added a commit that referenced this issue Mar 29, 2024
@dl8dtl
Merge pull request #1730 from stefanrueger/remove_avrdude_message
8516243 
Remove unused avrdude_message()

Fixes #1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused avrdude_message() stefanrueger/avrdude
3 participants
@mcuee @dl8dtl @stefanrueger