Add readline for MSYS2 mingw32/mingw64 build #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging this PR showed errors, so I reverted it. Strange, ... but there you go. I know too little about these things... |
|
Looking at the build log (https://github.com/avrdudes/avrdude/actions/runs/3308684165/jobs/5461248027), the issue is MSYS2 readline/termcap packaging issues mentioned here. On my local machine I can fix the issue by rebuilding termcap as per the I'll see what I can do to correct this issue using github action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the support for readline for the github action mingw32/mingw64 build.
Sign-off by xiaofanc@gmail.com