This repository has been archived by the owner on May 25, 2020. It is now read-only.
Upgrade to use 2.0 of symfony/psr-http-message-bridge #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpn273
changed the title
tarampampam
reviewed
May 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage 97.70% 97.70%
Complexity 105 105
=========================================
Files 23 23
Lines 262 262
=========================================
Hits 256 256
Misses 6 6 Continue to review full report at Codecov.
|
tarampampam
approved these changes
May 8, 2020
|
Thx for your contribution! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Laravel Passport, as of versions greater than 8.4, have now upgraded to use symfony/psr-http-message-bridge ^2.0. This now presents a conflict, and whether to decide to lock the Laravel Passport version or roadrunner-laravel. I have bumped the version from ^1.2 to ^2.0 and ran current PHPUnit tests, 63 has passed.
Checklist
I have updated the CHANGELOG.md to version 3.2.1 to state the upgrade to symfony/psr-http-message-bridge ^2.0