Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore minimized sticky clients #3709

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

kosorin
Copy link
Contributor

@kosorin kosorin commented Sep 29, 2022

If a sticky client is minimized on a tag not assigned to it, one has to switch to the tag to be able to restore the minimized client.
A minimized sticky client should be able to be restored with awful.client.restore().

Copy link
Member

@Aire-One Aire-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3709 (3714ec5) into master (4a140ea) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #3709      +/-   ##
==========================================
- Coverage   90.93%   90.91%   -0.03%     
==========================================
  Files         896      896              
  Lines       56630    56634       +4     
==========================================
- Hits        51495    51486       -9     
- Misses       5135     5148      +13     
Flag Coverage Δ
gcov 90.91% <50.00%> (-0.03%) ⬇️
luacov 93.66% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/awful/client.lua 77.77% <50.00%> (-0.23%) ⬇️
spawn.c 82.58% <0.00%> (-3.51%) ⬇️
tests/test-input-binding.lua 97.50% <0.00%> (-2.00%) ⬇️
tests/examples/screen/template.lua 96.64% <0.00%> (-0.21%) ⬇️
lib/wibox/widget/imagebox.lua 96.42% <0.00%> (+0.89%) ⬆️

@Elv13 Elv13 merged commit b16f628 into awesomeWM:master Sep 30, 2022
@kosorin kosorin deleted the restore-minimized-sticky branch October 1, 2022 00:17
actionless pushed a commit to actionless/awesome that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants