Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/6280 – Endpoint API #6283

Merged
merged 119 commits into from
Jan 12, 2018
Merged

issue/6280 – Endpoint API #6283

merged 119 commits into from
Jan 12, 2018

Conversation

DrewAPicture
Copy link
Contributor

@DrewAPicture DrewAPicture commented Jan 6, 2018 •
edited
Loading

Issue: #6280

@DrewAPicture DrewAPicture mentioned this pull request Jan 6, 2018
Closed
@DrewAPicture
Update from issue/6254.
cccf726
@DrewAPicture
A support for retrieving the endpoints registry via get_registry().
827d074
@DrewAPicture
Check if the endpoint ID arg is set before trying to access it in the…
1505686 
… $arguments array for Endpoint_Registry magic methods.
@DrewAPicture
Add base logic for instantiating an Endpoint object.
f9c44da
@DrewAPicture
Make get_endpoint() a first-order method.
7481d42
@DrewAPicture
Remove the notation for get_endpoint().
f2e1521
@DrewAPicture
Flesh out the Endpoint object with most vital properties, setters, an…
e035c5c 
…d getters.
@DrewAPicture
Add a $display_args property and getter, and incorporate it into the …
0212067 
…display() method.
@DrewAPicture
Move the Endpoint constructor up after the properties.
0780a56
@DrewAPicture
Check if display attributes have been passed before setting them.
efa8229
@DrewAPicture
Move setting the label back into the constructor from set_display_pro…
9dbf814 
…ps().
@DrewAPicture
Instantiate and collect Endpoint instantiation errors in a WP_Error o…
9b63119 
…bject.
@DrewAPicture
Use a more specific error code for when the view type isn't defined f…
20fbb7b 
…or the endpoint.
@DrewAPicture
Restore get_endpoint() as a second-order magic method.
a934cc4
@DrewAPicture
Take the logic from the former get_endpoint() and movie it to a build…
f113a34 
…_endpoint() method that returns a WP_Error object on failure.
@DrewAPicture
Add has_errors() and get_errors() helpers to Endpoint, further re-ord…
641a375 
…er some methods within the class structure.
@DrewAPicture
Add notations for get_endpoint() and register_endpoint().
47aa8fc
@DrewAPicture
Missing semicolon in Endpoint::has_errors().
76d5dc7
@DrewAPicture
Flesh out attribute hash notation for register_endpoint().
7a3cb69
@DrewAPicture
Endpoint views will be under a 'views' key upon retrieval.
3ee04bd
@DrewAPicture
Update from issue/6254.
c944edf
@DrewAPicture
Standardize throws notations on the \EDD_Exception marker interface f…
b9b97c4 
…or brevity in Reports\Data\Endpoint_Registry.
@DrewAPicture
More elegantly manage WP_Error handling on the return from build_endp…
7edc9a4 
…oint().
@DrewAPicture
Handle validating attributes and sub-attributes passed to register_en…
434f103 
…dpoint().
@DrewAPicture
Update from issue/6254.
be91feb
@DrewAPicture
Update from issue/6254.
59f059a
@DrewAPicture
Adjust Endpoint_Registry to extend the newly-abstracted Reports\Regis…
7477b2c 
…try.
@pippinsplugins pippinsplugins mentioned this pull request Jan 8, 2018
Closed
15 tasks
@DrewAPicture
Convert item_error_label tests to check the now-static property.
8e33a38
@DrewAPicture
Exclude display_args from validation.
0752185
@DrewAPicture
Make the display_args view argument truly optional. Still defaults to…
a56be68 
… an empty array.
@DrewAPicture
Add missing 'label' attributes to a bunch of Endpoint tests to furthe…
d54c95c 
…r narrow the field in which error tests operate.
@DrewAPicture
Remove a WP_Error-related test for the display_args view attribute, u…
5c3740f 
…pdate another one to demonstrate that passing an empty array will still succeed.
@DrewAPicture
Ensure Reports_Registry->register|unregister_endpoint() wrappers hand…
16d4429 
…le WP_Errors.
@DrewAPicture
Clarify required vs optional arguments for register_endpoint() and ad…
b534920 
…d_report().
@DrewAPicture
Standardize on $view_type as the $view|$typep variable of choice.
f9b46b0
@DrewAPicture
Add an Endpoint test for a setting a valid view.
68cda1f
@DrewAPicture
Move set_view() tests up above set_props() tests.
67d9081
@DrewAPicture
Add two tests for Endpoint::get_view().
82bb4c7
@DrewAPicture
Simplify some set_view() tests.
400f6cb
@DrewAPicture
Convert all Endpoint prop setters to private.
62747df
@DrewAPicture
Reorder Endpoint methods into get/set pairs.
ae9125a
@DrewAPicture
Add two tests each for get_id() and get_label() Endpoint methods, res…
535722b 
…pectively.
@DrewAPicture
Add two tests each for get_display_args(), get_display_callback(), an…
931e066 
…d get_data_callback() Endpoint methods, respectively.
@DrewAPicture
Add tests for has_errors() and get_errors() Endpoint methods.
d496460
@DrewAPicture DrewAPicture changed the title issue/6280 – (WIP) Endpoint API issue/6280 – Endpoint API Jan 12, 2018
@DrewAPicture DrewAPicture merged commit 27252d7 into issue/6236 Jan 12, 2018
@DrewAPicture DrewAPicture mentioned this pull request Jan 12, 2018
Merged
@cklosowski cklosowski deleted the issue/6280 branch September 29, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DrewAPicture