GetInfo use case implemented #45
Conversation
…all the import statements of everything.
There was a problem hiding this comment.
I really like this, the public methods are documented, no CA engine violations, and a good choice of what to show the user for the GetInfo case.
I think this might go in the Buy Menu after a user searches for a specific stock so they can make sure this is the stock they wanted to buy
|
I will merge this as soon as we have the new JSON data loader merged |
| /** | ||
| * The getInfoInputData parameter should follow the specifications laid out in that class. | ||
| * <p> | ||
| * This method implements the bulk of the GetInfo use case. | ||
| * Info is fetched using the Finnhub driver. | ||
| * | ||
| * @param getInfoInputData an InputData object following the relevant CA Engine rules | ||
| */ |
There was a problem hiding this comment.
I feel that the documentation needs to mention what the use case does, or rather, what the execute method does. currently, it just says it does the bulk of the use case, what does that mean?
Also, I don't think you need to mention it follows CA engine rules, the client doesn't really care about that. Instead, mention that the InputData contains the ticker
|
I have been informed that it is not bad that this is failing. It is likely due to the fact that this branch was created prior to some of the newer Maven architecture of our project being set up. The merge process for this will be non-trivial but not very difficult, since all I modified most recently was the interaction. |
I implemented the GetInfo use_case but I also modified a bunch of files cuz the switch to Maven format messed with all the imports so I needed to change a whole bunch of stuff.
Very important to thoroughly review this one though.
This is linked to Issue #29.