-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dark Mode support and customisation #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 2 small comments, looking good otherwise
Tatsi/Config/TatsiColors.swift
Outdated
} | ||
}() | ||
|
||
public var tint: UIColor = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rename this to link as well since you are using the link color instead of the tint color.
|
||
/// Defines colors that will be applied to the Tatsi elements. | ||
public protocol TatsiColors { | ||
var background: UIColor { get } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick description of where each color is used or what it's used for would be great.
Correction: Just fixed this for you, it wasn't that much work 😛 |
This PR adds support for customization using a
TatsiColors
protocol. It also adds great support for dark mode by default which might even take away the need to apply custom styling.Adding customized colors
This can simply be done by using the
TatsiConfig.default.colors
property which defaults toTatsiDefaultColors()
. Simply create your custom struct applying to theTatsiColors
protocol:Albums overview
Recents