Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook_url can't read from config ( Environment ) file. #3

Closed
rijojoseph57 opened this issue Sep 3, 2019 · 4 comments
Closed

webhook_url can't read from config ( Environment ) file. #3

rijojoseph57 opened this issue Sep 3, 2019 · 4 comments

Comments

@rijojoseph57
Copy link
Contributor

I found one issues while using this plugin. I was trying set webhook_url dynamically,
the webhook_url is not fetching the values from the config file , so i debugged the plugin and analysed that the this.webhook_url = this.serverless.service.custom.slack.webhook_url; is reading in the constructor. So before setting up the value the constructor get executes and the webhook_url is not setting the evaluated value from config.

The Solution I found is read the webhook_url from afterDeployFunction and afterDeployService
Add the same ( this.webhook_url = this.serverless.service.custom.slack.webhook_url; ) in this method as well.

Developers please consider this issue when you are updating the new version

@maartenvanvliet
Copy link
Contributor

Could you file a PR?

@rijojoseph57
Copy link
Contributor Author

I given the PR , please have a look

@rijojoseph57
Copy link
Contributor Author

Can you have a look on my PR ,

@maartenvanvliet
Copy link
Contributor

closed with #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants