Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MADV_DONTDUMP and MAP_ANONYMOUS do not exist on OpenBSD amd64 #45

Closed
stephane-martin opened this issue Nov 18, 2017 · 1 comment
Closed

MADV_DONTDUMP and MAP_ANONYMOUS do not exist on OpenBSD amd64 #45

stephane-martin opened this issue Nov 18, 2017 · 1 comment
Assignees
@awnumar
Labels
bug

Comments

@stephane-martin
Copy link

stephane-martin commented Nov 18, 2017 •
edited
Loading

Hello,

compilation fails on OpenBSD because MADV_DONTDUMP and MAP_ANONYMOUS do not exist in golang/x/sys/unix.

  • MADV_DONTDUMP is not actually supported by OpenBSD => should be dropped there
  • MAP_ANONYMOUS shoud exist, but strangely golang/x/sys/unix does not have it on amd64. But MAP_ANON is there (???) and can be used.
  • 0x00020000 does not exist on OpenBSD

Thanks!
@awnumar awnumar added the bug label Nov 18, 2017
@awnumar awnumar self-assigned this Nov 18, 2017
awnumar pushed a commit that referenced this issue Nov 18, 2017
memcall: handle openbsd explicitly
272996c 
This fixes #45.
@awnumar awnumar mentioned this issue Nov 18, 2017
Merged
@awnumar
Copy link
Owner

awnumar commented Nov 18, 2017 •
edited
Loading

Thanks for reporting this. In addition to fixing this issue, I have also created a patch against sys/unix that adds the MAP_ANONYMOUS flag to the set of OpenBSD constants.

This was referenced May 11, 2019
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awnumar awnumar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephane-martin @awnumar