Added cumulative statistics to support request counter #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As proposed in https://github.com/awolden/brakes/issues I added cumulative counters that are independent of buckets. These counter stream out total requests (timeouts, etc.) per breaker, as well as the diff between two report events. The latter is necessary to support Prometheus counters effectively. Counters are supported and named aligned with the Hystrix Metrics and Monitoring guide: https://github.com/Netflix/Hystrix/wiki/Metrics-and-Monitoring
|
This seems like a great addition 👍 Thanks for the PR. Can you increment the |
|
I increased the version to 2.7.0 |
awolden
approved these changes
Mar 15, 2019
|
I will merge and publish, this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #55 I added cumulative counters that are independent of buckets. These counter stream out total requests (timeouts, etc.) per breaker, as well as the diff between two report events. The latter is necessary to support Prometheus counters effectively.
Counters are supported and named aligned with the Hystrix Metrics and Monitoring guide: https://github.com/Netflix/Hystrix/wiki/Metrics-and-Monitoring