Affinity-based Feature Query Restructuring #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not tested yet, tries to query features on every thread, requiring major restructuring. Added affinity parameter to most available feature query functions.
By default feature queries should probably look at the current core/thread, instead of the attributes of the first core.
pinToCPU() requires the thread actually be running (by virtue of, e.g. SetThreadAffinityMask()), so we use a lock to coordinate this correctly.
Put stuff like hasCongruentISA() in main module, other procs like currentAffinity() in new info_common module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5, will ideally hold onto this until we can get this tested on Alder Lake samples. Work in progress.