Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): GraphQL operation is now launched from a new thread #1562

Merged
merged 5 commits into from
Nov 19, 2021

Conversation

raphkim
Copy link
Contributor

@raphkim raphkim commented Nov 4, 2021

Issue #, if available:

Description of changes:
AppSyncGraphQLOperation used to make a network call from the thread it was called in. This caused network request for getting request credentials to fail when called from main thread. This was addressed by dispatching request from a new thread.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@raphkim raphkim requested review from changxu0306 and a team November 4, 2021 00:43
Copy link
Contributor

@div5yesh div5yesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphkim raphkim merged commit f5a1dc2 into main Nov 19, 2021
@raphkim raphkim deleted the api-service-executor branch November 19, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants