feat(maplibre-adapter): MapLibreView and Geo adapter integration #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Notes:** - turn Adapter into an instantiable type to facilitate testing / dependency injection - reduce the boilerplate for MapView to work
**Notes:** - split implementation between MapLibreView and AmplifyMapView - the former is the standard MapBox/MapLibre map with built-in integration with the Amazon Location tilemap provider - the latter is a batteries-included MapView, with standard UI controls and upcoming integration with Search and Map markers
raphkim
reviewed
Nov 10, 2021
aws-geo-location/src/main/java/com/amplifyframework/geo/location/AWSLocationGeoPlugin.kt
Show resolved
Hide resolved
Comment on lines
-33
to
-39
| /** | ||
| * Configure MapLibre Adapter's auth provider. | ||
| */ | ||
| @Before | ||
| fun setUpAuth() { | ||
| AmplifyMapLibreAdapter.auth = TestCategory.forPlugin(AWSCognitoAuthPlugin()) as AuthCategory | ||
| } |
There was a problem hiding this comment.
i think this is good to leave here so that whenever we add new test suites in this class, we make sure to build a fresh category per test case
There was a problem hiding this comment.
I moved it to the MapViewTestActivity, but I'll move it back to re-create per test case
maplibre-adapter/src/main/java/com/amplifyframework/geo/maplibre/AmplifyMapLibreAdapter.kt
Show resolved
Hide resolved
maplibre-adapter/src/main/java/com/amplifyframework/geo/maplibre/view/AmplifyMapView.kt
Outdated
Show resolved
Hide resolved
maplibre-adapter/src/main/java/com/amplifyframework/geo/maplibre/view/AmplifyMapView.kt
Outdated
Show resolved
Hide resolved
|
few things to address before final approval:
|
…ify/amplify-android into feature/amplify-mapview
drochetti
changed the title
raphkim
approved these changes
Nov 23, 2021
sktimalsina
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.