Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): enable ap-northeast-3 region #13039

Closed
wants to merge 2 commits into from

Conversation

petercwk-aws
Copy link
Contributor

@petercwk-aws petercwk-aws commented Jul 31, 2023

In Draft mode because it depends on aws-amplify/amplify-category-api#1741. Please review so that this PR can be ready when the dependency is ready.

Description of changes

This PR enables support in ap-northeast-3 region (KIX)

Issue #, if available

Associated amplify-category-api PR: aws-amplify/amplify-category-api#1741

Description of how you validated changes

I set ap-northeast-3 in my ~/.aws/config for my amplify profile and created an app.

I ran:
amplify-dev init
amplify-dev add api (default graphQL options)
amplify-dev push

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -19,6 +19,7 @@ const Translate = {
'eu-south-1': 'eu-central-1',
'ap-northeast-1': 'ap-northeast-1',
'ap-northeast-2': 'ap-northeast-2',
'ap-northeast-3': 'ap-northeast-1',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate is not available in ap-northeast-3. Falling back to ap-northeast-3

https://docs.aws.amazon.com/general/latest/gr/translate-service.html

@@ -61,6 +63,7 @@ const Transcribe = {
'eu-south-1': 'eu-central-1',
'ap-northeast-1': latestTranscribeRegions >= 1 ? 'ap-northeast-1' : 'ap-northeast-2',
'ap-northeast-2': 'ap-northeast-2',
'ap-northeast-3': 'ap-northeast-1',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transcribe is not available in ap-northeast-3. Falling back to ap-northeast-1.

https://docs.aws.amazon.com/general/latest/gr/transcribe.html

@@ -82,6 +85,7 @@ const Rekognition = {
'eu-south-1': 'eu-central-1',
'ap-northeast-1': 'ap-northeast-1',
'ap-northeast-2': 'ap-northeast-2',
'ap-northeast-3': 'ap-northeast-1',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rekognition is not available in ap-northeast-3. Falling back to ap-northeast-1.

https://docs.aws.amazon.com/general/latest/gr/rekognition.html

@@ -103,6 +107,7 @@ const RekognitionAndTextract = {
'eu-south-1': 'eu-central-1',
'ap-northeast-1': 'us-east-1',
'ap-northeast-2': latestTextractRegions >= 1 ? 'ap-northeast-2' : 'us-east-1',
'ap-northeast-3': 'ap-northeast-2',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Textract is not available in ap-northeast-3. Falling back to ap-northeast-2.

https://docs.aws.amazon.com/general/latest/gr/textract.html

@@ -124,6 +129,7 @@ const Comprehend = {
'eu-south-1': 'eu-central-1',
'ap-northeast-1': latestComprehendRegions >= 1 ? 'ap-northeast-1' : 'us-east-1',
'ap-northeast-2': latestComprehendRegions >= 1 ? 'ap-northeast-2' : 'us-east-1',
'ap-northeast-3': 'ap-northeast-1',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprehend is not available in ap-northeast-3. Falling back to ap-northeast-1.

https://docs.aws.amazon.com/general/latest/gr/comprehend.html

@petercwk-aws petercwk-aws marked this pull request as ready for review August 2, 2023 19:30
@petercwk-aws petercwk-aws requested a review from a team as a code owner August 2, 2023 19:30
@petercwk-aws petercwk-aws reopened this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant