-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🤖 enable ap-northeast-3 region #13057
Conversation
packages/amplify-provider-awscloudformation/src/aws-predictions-regions.js
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/aws-predictions-regions.js
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/aws-predictions-regions.js
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/aws-predictions-regions.js
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/aws-predictions-regions.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge with e2e tests passing.
Can you run yarn cloud-e2e
or yarn cloud-e2e-circleci
?
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #13057 +/- ##
===========================================
+ Coverage 0.00% 48.45% +48.45%
===========================================
Files 1296 842 -454
Lines 149743 38038 -111705
Branches 1296 7789 +6493
===========================================
+ Hits 0 18432 +18432
+ Misses 148447 18016 -130431
- Partials 1296 1590 +294
... and 1243 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Rebased wit the dev branch and passed e2e tests here: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-E2E-Testing/batch/AmplifyCLI-E2E-Testing:61be36be-ad87-40be-b52e-471989855ee6?region=us-east-1# Test branch: dev...run-e2e/petercwk/kix |
Do not merge yet! this PR depends on aws-amplify/amplify-category-api#1741. Please review so that this PR can be ready when the dependency is ready.
Description of changes
This PR enables support in ap-northeast-3 region (KIX)
Issue #, if available
Associated amplify-category-api PR: aws-amplify/amplify-category-api#1741
Description of how you validated changes
I set ap-northeast-3 in my ~/.aws/config for my amplify profile and created an app.
I ran:
amplify-dev init
amplify-dev add api (default graphQL options)
amplify-dev push
Confirmed that AppSync api was deployed to my account in the ap-northeast-3 region.
Ran e2e tests here: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-E2E-Testing/batch/AmplifyCLI-E2E-Testing:61be36be-ad87-40be-b52e-471989855ee6?region=us-east-1#
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.