Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 enable ap-northeast-3 region #13057

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

petercwk-aws
Copy link
Contributor

@petercwk-aws petercwk-aws commented Aug 2, 2023

Do not merge yet! this PR depends on aws-amplify/amplify-category-api#1741. Please review so that this PR can be ready when the dependency is ready.

Description of changes

This PR enables support in ap-northeast-3 region (KIX)

Issue #, if available

Associated amplify-category-api PR: aws-amplify/amplify-category-api#1741

Description of how you validated changes

I set ap-northeast-3 in my ~/.aws/config for my amplify profile and created an app.

I ran:
amplify-dev init
amplify-dev add api (default graphQL options)
amplify-dev push

Confirmed that AppSync api was deployed to my account in the ap-northeast-3 region.

Ran e2e tests here: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/671107461633/projects/AmplifyCLI-E2E-Testing/batch/AmplifyCLI-E2E-Testing:61be36be-ad87-40be-b52e-471989855ee6?region=us-east-1#

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@petercwk-aws petercwk-aws marked this pull request as ready for review August 2, 2023 21:49
@petercwk-aws petercwk-aws requested a review from a team as a code owner August 2, 2023 21:49
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge with e2e tests passing.
Can you run yarn cloud-e2e or yarn cloud-e2e-circleci ?

@codecov-commenter
Copy link

Codecov Report

Merging #13057 (3a2c85f) into dev (ec9a2ba) will increase coverage by 48.45%.
Report is 285 commits behind head on dev.
The diff coverage is 59.37%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##              dev   #13057       +/-   ##
===========================================
+ Coverage    0.00%   48.45%   +48.45%     
===========================================
  Files        1296      842      -454     
  Lines      149743    38038   -111705     
  Branches     1296     7789     +6493     
===========================================
+ Hits            0    18432    +18432     
+ Misses     148447    18016   -130431     
- Partials     1296     1590      +294     
Files Changed Coverage Δ
...rmation/auth-stack-builder/auth-stack-transform.ts 91.30% <0.00%> (+91.30%) ⬆️
...tack-builder/auth-user-pool-group-stack-builder.ts 51.72% <ø> (+51.72%) ⬆️
...h-stack-builder/user-pool-group-stack-transform.ts 94.59% <0.00%> (+94.59%) ⬆️
.../src/provider-utils/awscloudformation/constants.ts 100.00% <ø> (+100.00%) ⬆️
...e-walkthrough-types/awsCognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...vice-walkthrough-types/cognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...y-category-function/src/commands/function/build.ts 0.00% <0.00%> (ø)
...ify-category-function/src/events/prePushHandler.ts 33.33% <0.00%> (+33.33%) ⬆️
...ider-utils/awscloudformation/utils/layerHelpers.ts 21.80% <0.00%> (+21.80%) ⬆️
...er-utils/awscloudformation/utils/storeResources.ts 30.38% <ø> (+30.38%) ⬆️
... and 58 more

... and 1243 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johnpc
Copy link
Contributor

johnpc commented Aug 3, 2023

@petercwk-aws
Copy link
Contributor Author

petercwk-aws commented Oct 6, 2023

@bombguy bombguy merged commit 92d2f2e into aws-amplify:dev Oct 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants