feat: add metrics for canary success rate #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
force-pushed
the
canary-client-tests
branch
2 times, most recently
from
873c5c7
to
36bfc1c
Compare
alharris-at
force-pushed
the
canary-client-tests
branch
from
c4d29ad
to
099ab44
Compare
AaronZyLee
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Emit a metric if our canary tests succeed or fail.
Issue #, if available
N/A
Description of how you validated changes
Had to validate via the manual trigger, again, duplicating some logic across
config.ymlandconfig.base.ymlto make that happen.Example failing workflow: https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api/1371/workflows/96afb76e-9caf-4bbb-88de-2a7e048af5f3/jobs/38163
Example succeeding workflow: https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api/1375/workflows/9c10ed75-54de-4ef3-9a7c-a6f2f5b9d43c/jobs/38165
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.