Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix smoke tests #13479

Merged
merged 1 commit into from
Dec 15, 2023
Merged

test: fix smoke tests #13479

merged 1 commit into from
Dec 15, 2023

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Dec 15, 2023 •
edited
Loading

Description of changes

Propagating fix for missing node-gyp dependency to smoke test workflow.
#13395 (comment)

Issue #, if available

Description of how you validated changes

Test run https://github.com/aws-amplify/amplify-cli/actions/runs/7226620347

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner December 15, 2023 20:13
@sobolk sobolk merged commit d1cc3c2 into dev Dec 15, 2023
11 checks passed
@sobolk sobolk deleted the fix-smoke-tests branch December 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardfoyle edwardfoyle edwardfoyle approved these changes

@0618 0618 0618 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolk @0618 @edwardfoyle