Adds PreTokenGeneration trigger #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 31, 2019 19:54
Removes parameters from parameters.json file that are either redundant or not strictly needed. This is to stay below the 60 parameter limit. fix(aws-amplify#1937)
undefobj
reviewed
Aug 23, 2019
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Why is this empty JSON needed? Is this populated with something?
There was a problem hiding this comment.
This will be populated with metadata when we add templates.
undefobj
reviewed
Aug 23, 2019
...r-utils/awscloudformation/triggers/PreTokenGeneration/function-template-dir/trigger-index.js
Show resolved
Hide resolved
undefobj
reviewed
Aug 23, 2019
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Similar to the above, why do we need these empty maps?
There was a problem hiding this comment.
This is a placeholder for template metadata.
undefobj
reviewed
Aug 23, 2019
haverchuck
changed the title
|
Is there any technical reason why the User Migration trigger was removed from this? |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix(#1844 )
Description of changes:
Adds PreTokenGeneration trigger.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.