fix(amplify-provider-awscloudformation): fix tests failing due to system-config-manager.js #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional-chaining to fix failing tests
|
Instead of adding more complexity, can we just change |
Oh, I didn't know that changing to |
….js to a typescript file
…tem-config-manager.ts
Codecov Report
@@ Coverage Diff @@
## master #7053 +/- ##
==========================================
+ Coverage 56.31% 56.43% +0.11%
==========================================
Files 445 445
Lines 21806 21859 +53
Branches 4363 4373 +10
==========================================
+ Hits 12280 12336 +56
- Misses 8711 8745 +34
+ Partials 815 778 -37
Continue to review full report at Codecov.
|
rajrajhans
changed the title
jhockett
approved these changes
Apr 10, 2021
packages/amplify-provider-awscloudformation/src/system-config-manager.ts
Outdated
Show resolved
Hide resolved
edwardfoyle
pushed a commit
to edwardfoyle/amplify-cli
that referenced
this pull request
Apr 12, 2021
…tem-config-manager.js (aws-amplify#7053)
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v4.48.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.48.0. |
akshbhu
pushed a commit
that referenced
this pull request
Jun 10, 2021
* fix(amplify-provider-awscloudformation): fix tests failing due to system-config-manager.js (#7053) * feat: s3 sse by default * chore: fix init push issue * chore: cleanup * test: whole lotta tests * test: update nondeterministic test * fix: serialize modifiers and improve test error handling * fix: add parameterization to ResourceModifier * fix: add type to sig * test: update test with new modifier structure * test: fix test * feat: add permission boundary to IAM roles * fix: update iam role modifier * test: add e2e test for perm bound * test: add unit tests for perm bound modifier * fix: fix regex * feat: switch to env-specific config * chore: dumping env perm bound changes * feat: fixup env-specific config and add headless support * chore: cleaning up things * test: more unit tests and e2e test * test: small test tweaks * chore: reverting some unintentional linting changes * fix: add update to env help text * test: add mock * chore: address PR comments * chore: use module var instead of global var * chore: rename permission boundary -> permissions boundary * fix: merge tpi instead of overwrite * chore: remove newline * fix: load creds for new env when checking policy * fix: test fixes * test: fix unit tests * test: fix profile selection * fix: change permissions boundary success text Co-authored-by: Raj Rajhans <me@rajrajhans.com>
|
👋 Hi, this pull request was referenced in the v5.0.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.0. |
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
…(ref aws-amplify#4618) * fix(amplify-provider-awscloudformation): fix tests failing due to system-config-manager.js (aws-amplify#7053) * feat: s3 sse by default * chore: fix init push issue * chore: cleanup * test: whole lotta tests * test: update nondeterministic test * fix: serialize modifiers and improve test error handling * fix: add parameterization to ResourceModifier * fix: add type to sig * test: update test with new modifier structure * test: fix test * feat: add permission boundary to IAM roles * fix: update iam role modifier * test: add e2e test for perm bound * test: add unit tests for perm bound modifier * fix: fix regex * feat: switch to env-specific config * chore: dumping env perm bound changes * feat: fixup env-specific config and add headless support * chore: cleaning up things * test: more unit tests and e2e test * test: small test tweaks * chore: reverting some unintentional linting changes * fix: add update to env help text * test: add mock * chore: address PR comments * chore: use module var instead of global var * chore: rename permission boundary -> permissions boundary * fix: merge tpi instead of overwrite * chore: remove newline * fix: load creds for new env when checking policy * fix: test fixes * test: fix unit tests * test: fix profile selection * fix: change permissions boundary success text Co-authored-by: Raj Rajhans <me@rajrajhans.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Optional chaining operator is used in packages/amplify-provider-awscloudformation/src/system-config-manager.js. However, since it is a JS file, and not a TS file, it isn't being processed by Babel and so some tests are failing ->
This PR converts
packages/amplify-provider-awscloudformation/src/system-config-manager.jsto a.tsfile (as suggested by @cjihrig)Issue #, if available
Description of how you validated changes
yarn testChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.