fix: generate OptionallyManagedCompositeIdentifier #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
optionally-managed-composite-id
branch
from
8de0aaf
to
0168fbb
Compare
…sort key fields are used
dpilch
force-pushed
the
optionally-managed-composite-id
branch
from
0168fbb
to
efb2c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Generate
OptionallyManagedCompositeIdentifierwhen pk is id and sort key fields are used.Release strategy needs to be developed because the
OptionallyManagedCompositeIdentifierdoes not exist in JS library currently. The strategy may be similar to lazy loading changes.Issue #, if available
Resolves #639
Dependent on aws-amplify/amplify-js#11707
Description of how you validated changes
Unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.