Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add gen2 e2e tests #833

Merged
merged 19 commits into from
May 3, 2024
Merged

test: add gen2 e2e tests #833

merged 19 commits into from
May 3, 2024

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented May 2, 2024

Description of changes

Added Gen2 e2e tests for graphql-generator related command

  • npx ampx generate outputs
  • npx ampx generate forms
  • npx ampx generate graphql-client-code

Codegen Paramaters Changed or Added

Issue #, if available

Description of how you validated changes

Unit and E2E tests passed. Link to E2E

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified
  • Changes are tested on windows. Some Node functions (such as path) behave differently on windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AaronZyLee AaronZyLee requested review from a team as code owners May 2, 2024 01:21
@AaronZyLee AaronZyLee marked this pull request as draft May 2, 2024 01:21
@AaronZyLee AaronZyLee marked this pull request as ready for review May 3, 2024 09:05
});
}).flat();
graphqlCodegenConfigs.forEach(config => {
// TODO: skip these tests as it will fail due to the duplicate graphql module. Will enable them once the issue is resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests fail due to the duplicate graphql module detected. Will explore if there are any workarounds before going to the verdaccio registry. This will be addressed in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phani-srikar phani-srikar merged commit cc88595 into main May 3, 2024
4 checks passed
@palpatim palpatim deleted the gen2-codegen-e2e branch May 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants