fix: make the android modules compatible with AGP 8 (#12371)

aws-amplify · Oct 20, 2023 · 6bef5b8 · 6bef5b8
2 parents 1497592 + 76ca2e8
commit 6bef5b8
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 4 deletions.
diff --git a/packages/amazon-cognito-identity-js/android/build.gradle b/packages/amazon-cognito-identity-js/android/build.gradle
@@ -1,3 +1,8 @@
+import com.android.Version
+
+def agpVersion = Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
+def androidManifestPath = agpVersion >= 7 ? 'src/main/AndroidManifest.xml' : 'src/hasNamespace/AndroidManifest.xml'
+
 buildscript {
     repositories {
         mavenCentral()
@@ -15,6 +20,10 @@ def safeExtGet(prop, fallback) {
 }
 
 android {
+    if (agpVersion >= 7) {
+        namespace "com.amazonaws"
+    }
+
     compileSdkVersion safeExtGet('compileSdkVersion', 26)
     buildToolsVersion safeExtGet('buildToolsVersion', '26.0.3')
 
@@ -24,6 +33,11 @@ android {
         versionCode 1
         versionName "1.0"
     }
+    sourceSets {
+        main {
+            manifest.srcFile androidManifestPath
+        }
+    }
     lintOptions {
         abortOnError false
     }

diff --git a/packages/amazon-cognito-identity-js/android/src/hasNamespace/AndroidManifest.xml b/packages/amazon-cognito-identity-js/android/src/hasNamespace/AndroidManifest.xml
@@ -0,0 +1,4 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+          package="com.amazonaws">
+
+</manifest>
diff --git a/packages/amazon-cognito-identity-js/android/src/main/AndroidManifest.xml b/packages/amazon-cognito-identity-js/android/src/main/AndroidManifest.xml
@@ -1,4 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.amazonaws">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 </manifest>
diff --git a/packages/rtn-push-notification/android/build.gradle b/packages/rtn-push-notification/android/build.gradle
@@ -1,3 +1,8 @@
+import com.android.Version
+
+def agpVersion = Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
+def androidManifestPath = agpVersion >= 7 ? 'src/main/AndroidManifest.xml' : 'src/hasNamespace/AndroidManifest.xml'
+
 buildscript {
     def kotlin_version = rootProject.ext.has('kotlinVersion')
             ? rootProject.ext.get('kotlinVersion')
@@ -26,13 +31,23 @@ def getExtOrDefault(prop) {
 }
 
 android {
+    if (agpVersion >= 7) {
+        namespace 'com.amazonaws.amplify.rtnpushnotification'
+    }
+
     compileSdkVersion getExtOrDefault('compileSdkVersion')
 
     defaultConfig {
         minSdkVersion getExtOrDefault('minSdkVersion')
         targetSdkVersion getExtOrDefault('targetSdkVersion')
     }
 
+    sourceSets {
+        main {
+            manifest.srcFile androidManifestPath
+        }
+    }
+
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8

diff --git a/packages/rtn-push-notification/android/src/hasNamespace/AndroidManifest.xml b/packages/rtn-push-notification/android/src/hasNamespace/AndroidManifest.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.amazonaws.amplify.rtnpushnotification">
+
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+    <application>
+        <activity
+            android:name=".PushNotificationLaunchActivity"
+            android:launchMode="singleInstance"
+            android:exported="false" />
+
+        <service android:name=".PushNotificationHeadlessTaskService" />
+
+        <service
+            android:name=".PushNotificationFirebaseMessagingService"
+            android:exported="false">
+            <intent-filter>
+                <action android:name="com.google.firebase.MESSAGING_EVENT" />
+            </intent-filter>
+        </service>
+    </application>
+</manifest>
diff --git a/packages/rtn-push-notification/android/src/main/AndroidManifest.xml b/packages/rtn-push-notification/android/src/main/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.amazonaws.amplify.rtnpushnotification">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
     <application>