Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notifications): Integrate refactored Android common utils #11125

Conversation

cshfang
Copy link
Member

@cshfang cshfang commented Mar 23, 2023

Description of changes

This PR updates React Native Push Notification to integrate with the latest refactoring of the Amplify Android common utilities.

Description of how you validated changes

  • Tested locally with sample app.
  • $ yarn test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cshfang cshfang force-pushed the push-notification/integrate-android-refactor branch 4 times, most recently from d75d1af to bea17dd Compare March 23, 2023 09:05
@cshfang cshfang force-pushed the push-notification/integrate-android-refactor branch from bea17dd to 1b1a69f Compare March 23, 2023 09:16
@cshfang cshfang marked this pull request as ready for review March 23, 2023 09:30
@cshfang cshfang requested a review from a team as a code owner March 23, 2023 09:30
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshfang cshfang merged commit 5f8702e into aws-amplify:push-notification/main Mar 27, 2023
@cshfang cshfang deleted the push-notification/integrate-android-refactor branch March 27, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants