-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AmazonAIConvertPredictionsProvider.ts #11453
Conversation
correct improper import syntax. this is causing ng build optimization error
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11453 +/- ##
==========================================
- Coverage 83.23% 83.22% -0.01%
==========================================
Files 274 274
Lines 20523 20523
Branches 4436 4436
==========================================
- Hits 17083 17081 -2
- Misses 3152 3154 +2
Partials 288 288
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @gerrytsui thank you for your contribution! Do you have an issue you can reference that describes the problem this PR aims to resolve? #11455 potentially looks like one |
@nadetastic , correct. I encountered the exact problem described in #11455 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue was introduced in #11377 to fix the missing polyfill for Predictions in React Native.
The import statement was suggested by the buffer polyfill doc. However, given the amazon-cognito-identity-js uses the buffer polyfill without trailing "/"
just fine, it's ok to remove it here.
Note: The failing bundle size task is unrelated to this change/fix and being investigated internally. |
correct improper import syntax. this is causing ng build optimization error
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.