Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AmazonAIConvertPredictionsProvider.ts #11453

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

gerrytsui
Copy link
Contributor

@gerrytsui gerrytsui commented Jun 2, 2023

correct improper import syntax. this is causing ng build optimization error

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

correct improper import syntax. this is causing ng build optimization error
@gerrytsui gerrytsui requested a review from a team as a code owner June 2, 2023 19:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #11453 (71ec45e) into main (08fc7ee) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #11453      +/-   ##
==========================================
- Coverage   83.23%   83.22%   -0.01%     
==========================================
  Files         274      274              
  Lines       20523    20523              
  Branches     4436     4436              
==========================================
- Hits        17083    17081       -2     
- Misses       3152     3154       +2     
  Partials      288      288              
Impacted Files Coverage Δ
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 83.15% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nadetastic
Copy link
Member

Hi @gerrytsui thank you for your contribution! Do you have an issue you can reference that describes the problem this PR aims to resolve? #11455 potentially looks like one

@gerrytsui
Copy link
Contributor Author

@nadetastic , correct. I encountered the exact problem described in #11455

Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was introduced in #11377 to fix the missing polyfill for Predictions in React Native.

The import statement was suggested by the buffer polyfill doc. However, given the amazon-cognito-identity-js uses the buffer polyfill without trailing "/" just fine, it's ok to remove it here.

@stocaaro
Copy link
Member

Note: The failing bundle size task is unrelated to this change/fix and being investigated internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants