Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set resolution for octokit/request-error due to breaking change in v4 for node@16 users #11510

Conversation

erinleigh90
Copy link
Contributor

@erinleigh90 erinleigh90 commented Jun 16, 2023

Description of changes

@octokit/core@4.2.2 introduces a breaking change by upgrading their dependency on @octokit/request-error to v4, which no longer supports the use of node@16. This PR sets a resolution for octokit/request-error to unblock our pipeline until octokit fixes their issue.

Description of how you validated changes

yarn succeeds locally

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@erinleigh90 erinleigh90 requested a review from a team as a code owner June 16, 2023 19:24
@erinleigh90 erinleigh90 merged commit 2e1e1f5 into aws-amplify:main Jun 16, 2023
@erinleigh90 erinleigh90 deleted the build/resolution-rule-octokit-request-error branch June 16, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants