feat(data): add 'sortDirection' support for list and index queries #13164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhan-aws
reviewed
Mar 25, 2024
packages/api-graphql/__tests__/internals/generateClient.test.ts
Outdated
Show resolved
Hide resolved
iartemiev
requested changes
Mar 26, 2024
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
iartemiev
previously approved these changes
Mar 26, 2024
svidgen
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Just one concern that prevents me from hitting the approve bubble:
The Q below about listTodos -> query. I don't understand how/why that changed. If it was incorrect previously, why weren't the tests failing? (Or were they? But, if they were, how did they make it into main???)
packages/api-graphql/__tests__/internals/generateClient.test.ts
Outdated
Show resolved
Hide resolved
packages/api-graphql/__tests__/internals/server/generateClientWithAmplifyInstance.test.ts
Outdated
Show resolved
Hide resolved
svidgen
previously approved these changes
Mar 27, 2024
svidgen
approved these changes
Mar 27, 2024
iartemiev
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
feat(data): add 'sortDirection' support for list and index queries
Corresponding types PR
Note: PR checks will fail until the corresponding types PR has been mergedIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.