fix(auth): signUp should always return a userId #13181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
changed the title
cshfang
previously approved these changes
Mar 27, 2024
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
ashwinkumar6
force-pushed
the
issue-12998
branch
from
4987c82
to
86f99bb
Compare
israx
approved these changes
Mar 27, 2024
cshfang
approved these changes
Mar 27, 2024
Samaritan1011001
pushed a commit
that referenced
this pull request
Apr 1, 2024
* fix(auth): signup should always return a userId * add unit tests * Update packages/auth/__tests__/providers/cognito/signUp.test.ts Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com> * address feedback --------- Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com> Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
#12998
Description of how you validated changes
Tested the following flows and verified
signUpalways contains a userIdsignUp(code) ->confirmSignUp->signInsignUp(link) -> verify user using link ->signInsignUp-> Pre sign-up Lambda trigger ->signInsignUp(code, autoSignIn) ->confirmSignUp->autoSignInsignUp(link, autoSignIn) -> verify user using link ->autoSignInsignUp(autoSignIn) -> Pre sign-up Lambda trigger ->autoSignInChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.