Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Update API overload types #13214

Merged
merged 5 commits into from
Apr 5, 2024
Merged

[Fix] Update API overload types #13214

merged 5 commits into from
Apr 5, 2024

Conversation

ashika112
Copy link
Member

@ashika112 ashika112 commented Apr 3, 2024 •
edited
Loading

Description of changes

  • The overloads for the storage APIs were missing type for unionized input.
  • Remove un-used type
  • Refactor type name

Description of how you validated changes

  • Unit and Integ tests were run
  • Manually tested it

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashika112 ashika112 requested review from a team as code owners April 3, 2024 01:12
@ashika112 ashika112 changed the base branch from main to gen2-storage April 3, 2024 01:12
@ashika112 ashika112 removed request for a team April 3, 2024 01:45
@ashika112 ashika112 merged commit 58b86bb into aws-amplify:gen2-storage Apr 5, 2024
28 checks passed
@ashika112 ashika112 deleted the update/type-overloads branch April 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinleigh90 erinleigh90 erinleigh90 approved these changes

@Samaritan1011001 Samaritan1011001 Samaritan1011001 approved these changes

@jimblanc jimblanc jimblanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashika112 @jimblanc @Samaritan1011001 @erinleigh90