chore(analytics): enable linting on __tests__ #13430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/chore/analytics/lint-test
branch
from
9b0cd1e
to
caacf4e
Compare
ashika112
reviewed
May 24, 2024
| @@ -46,7 +46,7 @@ describe('Analytics Personalize API: flushEvents', () => { | |||
| await new Promise(process.nextTick); | |||
| expect(mockResolveConfig).toHaveBeenCalledTimes(1); | |||
| expect(mockResolveCredentials).toHaveBeenCalledTimes(1); | |||
| const { trackingId, ...configWithoutTrackingId } = mockPersonalizeConfig; | |||
| const { trackingId: _, ...configWithoutTrackingId } = mockPersonalizeConfig; | |||
There was a problem hiding this comment.
Do we even need to keep trackingId if we are not using it?
There was a problem hiding this comment.
This expression was for removing the trackingId property while creating a new copy from the mockPersonalizeConfig, I didn't want to refactor it completely from the original code.
There was a problem hiding this comment.
i think this might be missed artifact right? We should either check if trackingId's value or remove it , IMO. but non blocking so i will approve this PR :)
jimblanc
approved these changes
May 28, 2024
ashika112
approved these changes
May 28, 2024
cshfang
approved these changes
May 28, 2024
HuiSF
force-pushed
the
hui/chore/analytics/lint-test
branch
from
caacf4e
to
fea056c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See each commit message for details.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.