-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(in-app-messaging): update InAppMessagingDisplay and useInAppMessage #9088
feat(in-app-messaging): update InAppMessagingDisplay and useInAppMessage #9088
Conversation
Codecov Report
@@ Coverage Diff @@
## in-app-messaging/main #9088 +/- ##
======================================================
Coverage 78.00% 78.00%
======================================================
Files 250 250
Lines 18115 18115
Branches 3885 3885
======================================================
Hits 14131 14131
Misses 3854 3854
Partials 130 130 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, Caleb 🚢
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
Follow up to PR #9026.
handleAction
content
values to prevent accessing falsy values inuseInAppMessage
onActionCallback
inonPress
passed to buttonsgetContentProps
Issue #, if available
NA
Description of how you validated changes
Manually tested in sample app
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.