Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(in-app-messaging): add useDeviceOrientation hook #9881

Conversation

calebpollman
Copy link
Member

@calebpollman calebpollman commented May 7, 2022

Description of changes

Add useDeviceOrientation hook and unit tests

Issue #, if available

NA

Description of how you validated changes

  • Manually tested in React Native examples apps using versions 0.63 and 0.68
  • Added unit tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested review from cshfang and removed request for Ashish-Nanda May 7, 2022 00:07
Copy link
Member

@Samaritan1011001 Samaritan1011001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise it looks good to me

@calebpollman calebpollman changed the title chore(in-app-messaging): add useOrientation hook chore(in-app-messaging): add useDeviceOrientation hook May 9, 2022
Copy link
Member

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a change you should make but approving pending that

calebpollman and others added 2 commits May 9, 2022 15:59
@calebpollman calebpollman merged commit 12fddc3 into aws-amplify:in-app-messaging/staging May 9, 2022
@calebpollman calebpollman deleted the chore/add-use-orientation-hook branch May 9, 2022 23:21
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server amplify-help forum.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants