-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(in-app-messaging): add useDeviceOrientation hook #9881
chore(in-app-messaging): add useDeviceOrientation hook #9881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
...t-native/src/InAppMessaging/components/hooks/useOrientation/__tests__/useOrientation.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but otherwise it looks good to me
...ws-amplify-react-native/src/InAppMessaging/components/hooks/useOrientation/useOrientation.ts
Outdated
Show resolved
Hide resolved
…lify-js into in-app-messaging/staging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a change you should make but approving pending that
packages/aws-amplify-react-native/src/InAppMessaging/components/hooks/index.ts
Outdated
Show resolved
Hide resolved
…s/hooks/index.ts Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
Add
useDeviceOrientation
hook and unit testsIssue #, if available
NA
Description of how you validated changes
0.63
and0.68
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.