add missing sql statements and check for existing records #116
Conversation
**Notes:** - refactored the SQL statement creation to be aligned with the GraphQL one. Now both share a common protocol and structure (`DataStoreStatement`) so each kind of different statement has its own place. This simplifies maintenance and API documentation - added missing `delete` and `update` SQL statements - added `exists` to `StorageEngineAdapter` - added more tests and documentation
|
@palpatim I understand that this PR conflicts with yours a little bit. Let me know if you have any concerns when merging. The main part of this PR that connects to yours is: StorageEngineAdapter.exists(_ modelType: Model.Type, withId id: Identifier) throws -> Bool |
| @@ -0,0 +1,338 @@ | |||
| // | |||
There was a problem hiding this comment.
This file was just renamed. Only a few test cases here are actually new (not sure why GitHub didn't pick it up as a rename and rendered the proper diff)
**Notes:** - removed `QueryTranslator` and `Query` - added tests for more tests to `StorageEngineAdapter`
| var statement = "insert into \(schema.name) " | ||
| statement += "(\(columns.joined(separator: ", ")))\n" | ||
|
|
||
| let variablePlaceholders = Array(repeating: "?", count: columns.count).joined(separator: ", ") |
There was a problem hiding this comment.
Heaven forbid we ever hit it, but do I remember that SQLite has a limit on the number of bind variables on the order of 1,000? Might be worth verifying that and including it the documentation
There was a problem hiding this comment.
knocks on wood 😅
Thanks for the callout. I created #122 to track it
| /// - Returns: a list of columns that can be used in `select` SQL statements | ||
| internal func joinedAsSelectedColumns(_ columns: [String], perLine: Int = 3) -> String { | ||
| return columns.enumerated().reduce("") { partial, entry in | ||
| let spacer = entry.offset == 0 || entry.offset % perLine == 0 ? "\n " : " " |
There was a problem hiding this comment.
nit: consider using isMultipleOf(_:) in place of == 0 to enhance readability
Notes:
DataStoreStatement) so each kind of different statement has its own place. This simplifies maintenance and API documentationdeleteandupdateSQL statementsexiststoStorageEngineAdapterBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.