Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): fix copy_configuration script #3635

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

lawmicha
Copy link
Member

@lawmicha lawmicha commented Apr 25, 2024

Issue #

Description

This fixes the copy configuration script, which was modified to copy the outputs file. but replaced the previous amplifyconfiguration.json instead of it being an addition

The change that introduced the issue https://github.com/aws-amplify/amplify-swift/pull/3567/files#diff-afbd7f754fa78d6674c0136cafca4f962448f9cea32199a51f5e354694dfb75d

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner April 25, 2024 21:19
@lawmicha lawmicha merged commit 690dbc4 into main Apr 25, 2024
64 checks passed
@lawmicha lawmicha deleted the test.storage-gen2-integ branch April 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants