Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(predictions): add attempt count changes and unit tests #3657

Merged
merged 3 commits into from
May 6, 2024

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Add unit tests and attempt count changes

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash marked this pull request as ready for review April 30, 2024 21:59
@thisisabhash thisisabhash requested a review from a team as a code owner April 30, 2024 21:59
@thisisabhash thisisabhash merged commit 22e02fa into feat/no-light-support May 6, 2024
62 of 74 checks passed
@thisisabhash thisisabhash deleted the chore/attempt-count-changes branch May 6, 2024 15:50
thisisabhash added a commit that referenced this pull request May 7, 2024
* chore(predictions): add attempt count changes and unit tests

* remove test url

* Add coding keys for Challenge object
thisisabhash added a commit that referenced this pull request Jul 1, 2024
* chore(predictions): add attempt count changes and unit tests

* remove test url

* Add coding keys for Challenge object
thisisabhash added a commit that referenced this pull request Aug 22, 2024
* chore(predictions): add attempt count changes and unit tests

* remove test url

* Add coding keys for Challenge object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants