chore(ui): Bump xstate to ^4.33.0 #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e66a528 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wlee221
commented
Aug 9, 2022
jacoblogan
approved these changes
Aug 9, 2022
0618
approved these changes
Aug 9, 2022
zchenwei
reviewed
Aug 9, 2022
| @@ -42,7 +42,7 @@ | |||
| "dependencies": { | |||
| "lodash": "4.17.21", | |||
| "style-dictionary": "3.7.0", | |||
| "xstate": "^4.30.6", | |||
| "xstate": "^4.33.0", | |||
There was a problem hiding this comment.
For my knowledge, why not pin the version?
There was a problem hiding this comment.
Good question!
This is to avoid package duplication: Gatsby depends on xstate@^4.x.x, so if we pin the version, customer will get duplicated versions of xstate. And we found that duplicated xstate causes runtime errors.
More details here! #1545
zchenwei
approved these changes
Aug 9, 2022
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bumping xstate to 4.33.0, which contains statelyai/xstate#3126 that fixes #764.
Issue #, if available
#764
Description of how you validated changes
Build and e2e tests passing. This is not really a change in customer's end, because we pointed to latest
xstateanyway.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.