chore(liveness): Update state machine flow for no lights #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d9a4d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thaddmt
reviewed
May 28, 2024
...es/react-liveness/src/components/FaceLivenessDetector/LivenessCheck/LivenessCameraModule.tsx
Outdated
Show resolved
Hide resolved
packages/react-liveness/src/components/FaceLivenessDetector/service/machine/machine.ts
Outdated
Show resolved
Hide resolved
esauerbo
changed the title
Base automatically changed from
liveness/pass-nolight-challenge
to
liveness/alpha
May 29, 2024 19:30
esauerbo
force-pushed
the
liveness/nolight-flow
branch
from
8588343
to
306d5b1
Compare
reesscot
reviewed
May 29, 2024
...ss/src/components/FaceLivenessDetector/LivenessCheck/__tests__/LivenessCameraModule.test.tsx
Outdated
Show resolved
Hide resolved
reesscot
reviewed
May 29, 2024
...ss/src/components/FaceLivenessDetector/LivenessCheck/__tests__/LivenessCameraModule.test.tsx
Outdated
Show resolved
Hide resolved
…y/amplify-ui into liveness/nolight-flow
thaddmt
previously approved these changes
May 29, 2024
packages/react-liveness/src/components/FaceLivenessDetector/service/machine/machine.ts
Outdated
Show resolved
Hide resolved
packages/react-liveness/src/components/FaceLivenessDetector/service/machine/machine.ts
Outdated
Show resolved
Hide resolved
reesscot
approved these changes
May 30, 2024
zchenwei
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
recordingto handle no lights challenge. (Move straight tosuccessstate afterhasFaceMatchedInOvalcondition is met)Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.