-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native): Update references to RN #4407
Conversation
…ibrary update problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor req for changes on the specific version we recommend. Basically s/0.68.0/0.68.2 in all the changed files
src/fragments/lib/datastore/js/getting-started/30_platformIntegration.mdx
Outdated
Show resolved
Hide resolved
src/fragments/lib/datastore/js/getting-started/30_platformIntegration.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 Thanks Aaron
The current guide leads customers to a failing
npm install
command. This allows customers to have a productive experience while the work to get back onto@next
takes place.Issue #: amplify-js#10017
Description of changes:
The Amplify RN getting started guide depends upon
@react-native-picker/picker
as a peer dependency.@react-native-picker/picker
is incompatible with the latest version ofreact-native
.While we wait for the library to be updated (library issue), this will help our getting started customers remain on the last working
react-native
version.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.