Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): Update references to RN #4407

Merged
merged 9 commits into from
Jun 23, 2022
Merged

Conversation

stocaaro
Copy link
Member

The current guide leads customers to a failing npm install command. This allows customers to have a productive experience while the work to get back onto @next takes place.

Issue #: amplify-js#10017

Description of changes:
The Amplify RN getting started guide depends upon @react-native-picker/picker as a peer dependency. @react-native-picker/picker is incompatible with the latest version of react-native.

While we wait for the library to be updated (library issue), this will help our getting started customers remain on the last working react-native version.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro requested a review from a team as a code owner June 23, 2022 17:50
@stocaaro stocaaro requested a review from a team June 23, 2022 17:50
@timngyn timngyn added the run-tests Label to run tests on PRs from a fork label Jun 23, 2022
@github-actions github-actions bot removed the run-tests Label to run tests on PRs from a fork label Jun 23, 2022
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor req for changes on the specific version we recommend. Basically s/0.68.0/0.68.2 in all the changed files

Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stocaaro and others added 6 commits June 23, 2022 13:22
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
@stocaaro stocaaro dismissed iartemiev’s stale review June 23, 2022 18:38

Merged instead accepted

Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Thanks Aaron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants