fix: type error for Breadcrumbs component #6813

katiegoines · 2024-01-22T18:39:19Z

Description of changes:

platform is currently typed as required for the Breadcrumbs primitive but is potentially undefined (in the case of Gen2 or the Contribute page)

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

Which platform(s) are affected by this PR (if applicable)?

Please add the product(s)/platform(s) affected to the PR title

Checks

Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

ref: MDX: [link](https://docs.amplify.aws/)
HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Add tests for usePathWithoutHash * Add test to check that url is not modified if it doesn't have a hashmark

…6814)

…callout (#6820)

#6802) * simple unit test to ensure that the ProtectedAccountMessage is on the Admin UI start page * add test to ensure protected messaging hasn't changed * add comments to ProtectedAccountMessage component --------- Co-authored-by: Jacob Logan <lognjc@amazon.com>

* feat: add details to In-App Messaging migration guide * Update src/pages/[platform]/build-a-backend/more-features/in-app-messaging/in-app-messaging-migration-guide/index.mdx Co-authored-by: ManojNB <manojnb95@gmail.com> * Update wording on message comment * Populate identifyUser properties for guide --------- Co-authored-by: ManojNB <manojnb95@gmail.com>

* feat: add details to Push Notifications migration guide * Populate identifyUser properties for guide

* Update banner on prev BACB * Update wording

* Add tests for useTabKeyDetection * Add comment for helper function and add test for null ref.current

…6794) * Add module name mapper for 'src/directory' * Add tests for useRouteFinder * Update workflow to generate the json files * Update import paths with new module name mapper * Rename typo, tests -> test * Co-locate hook for version switcher and rename useRouteFinder to useVersionSwitcher * Fix typo * Simplify logic for useVersionSwitcherPath * Add comment for hook

* Add tests for getCustomStaticPath * Clean up to use only platform array

* fix: update gen2 quickstart guide * update alt text

* Add module name mapper for 'src/directory' * Add tests for useRouteFinder * Update workflow to generate the json files * Update import paths with new module name mapper * Rename typo, tests -> test * Add tests for getChildPageNodes * Remove outdated test

* Add module name mapper for 'src/directory' * Add tests for useRouteFinder * Update workflow to generate the json files * Update import paths with new module name mapper * Rename typo, tests -> test * Add tests for findDirectoryNode

…mum watchOS version (#6833) * chore(swift): update minimum xcode version for all platforms and minimum watchOS version * Address review comments

* Update index.mdx * Update index.mdx

* Preload s_code * Use prefetch for analytics scripts * Try preload

* Handle links with specified platform and add tests * Refactor out href logic into hook * Fix typo * Remove uncessary comment * Revert "Refactor out href logic into hook" This reverts commit 9bb57f7. * Typo * Update jest setup to mock router context * Add comment for doMock * Remove commented out lines

…m provider with CDK construct (#6902) * Update index.mdx * possessive apos --------- Co-authored-by: Chris Bonifacio <christopher.bonifacio@gmail.com>

* fix storage upload docs

* fix: size of AWS logo in footer and aria-label * remove aria-hidden on logo

* wip - iterate on simplification of "build a backend" section * iterate on defineData section * move backend.ts to callout last in the build a backend section * add note for data resource file * update auth section of build a backend * Properly cite Amplify (Gen 2) Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * remove file path in code block Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * end sentence with period Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * clarification on note Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * clarify default comments and code were shortened Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * remove code path since in accordion header Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * remove file path comment Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * Update wording for callout Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * add title to js block Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * add title to js codeblock Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * update step 3 header Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * remove codepath from block Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * clarify there is one step to complete Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * update step 2 header Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * add abbreviated comments to auth rule snippet Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * add comment abbreviation to code block Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> * remove externalProviders from code sample * update to use code highlights instead of diff * Update src/fragments/gen2/quickstart/build-a-backend.mdx --------- Co-authored-by: Heather Pundt <119376175+heatheramz@users.noreply.github.com> Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>

* fix: add domainPrefix to example of social provider * Update src/pages/gen2/build-a-backend/auth/add-social-provider/index.mdx Co-authored-by: josef <josef.aidt@gmail.com> --------- Co-authored-by: josef <josef.aidt@gmail.com>

* add route * add vite + react guide * Update src/pages/gen2/start/quickstart/vite-react-app/index.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/gen2/start/quickstart/vite-react-app/index.mdx * Update src/pages/gen2/start/quickstart/vite-react-app/index.mdx --------- Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>

…onfigureAmplify(); (#6904) - fix: add WidgetsFlutterBinding.ensureInitialized(); before await _configureAmplify();

mergify · 2024-02-15T13:51:32Z

@katiegoines, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

What is the source address of the redirect? (Where are you trying to redirect from?)
What is the target address of the redirect? (Where are you trying to redirect to?)
Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

mergify · 2024-02-15T13:59:24Z

⚠️ The sha of the head commit of this PR conflicts with #6912. Mergify cannot evaluate rules on this PR. ⚠️

platform typed as optional

0d731df

katiegoines requested a review from a team as a code owner January 22, 2024 18:39

timngyn and others added 9 commits January 22, 2024 12:31

Add tests for usePathWithoutHash (#6795)

90de484

* Add tests for usePathWithoutHash * Add test to check that url is not modified if it doesn't have a hashmark

Removing unused files from utils directory (#6798)

dc1903a

fix: link to ssr migration guide should be nextjs platform specific (#…

95aca81

…6814)

Remove LinkTagCheck workflow (#6817)

ded0f2c

chore(js-ssr): fix nextjs version callout and add cognito rate limit …

547823f

…callout (#6820)

Removed repetition (#6822)

d1a0e40

Co-locate slug.js next in MDXComponents (#6825)

ab7ac10

hbuchel previously approved these changes Jan 23, 2024

View reviewed changes

cshfang and others added 18 commits January 23, 2024 14:52

feat: add details to Push Notifications migration guide (#6823)

edbcf70

* feat: add details to Push Notifications migration guide * Populate identifyUser properties for guide

changed the docs to use npx prefix (#6812)

d9bf316

Clarified "Legacy" designation in Auth.signUp/Auth.signIn (#6746)

32fd3d4

Add missing semicolon (#6831)

9768313

Add banner for prev version project setup (#6829)

85650ab

* Update banner on prev BACB * Update wording

Throw an error if unable to match for the meta object (#6834)

92287f2

Add tests for useTabKeyDetection (#6818)

f3927ed

* Add tests for useTabKeyDetection * Add comment for helper function and add test for null ref.current

feat: add React Native migration details (#6828)

de93b27

Add test for useCurrentPlatform (#6796)

ad6c6ab

Add tests for getCustomStaticPath (#6797)

081e3f7

* Add tests for getCustomStaticPath * Clean up to use only platform array

Add tests for useClickOutside (#6815)

7387143

fix: Update Amplfiy Gen 2 quickstart guide (#6835)

44e64dd

* fix: update gen2 quickstart guide * update alt text

Add tests for findDirectoryNode (#6808)

acb49b1

* Add module name mapper for 'src/directory' * Add tests for useRouteFinder * Update workflow to generate the json files * Update import paths with new module name mapper * Rename typo, tests -> test * Add tests for findDirectoryNode

fix: Analytics JS fragments in Angular, React, Vue, and Next.js (#6745)

7f15f35

fix: Remove @ from Auth SSR import path. (#6837)

d8950d2

chore(swift): update minimum xcode version for all platforms and mini…

b1531c2

…mum watchOS version (#6833) * chore(swift): update minimum xcode version for all platforms and minimum watchOS version * Address review comments

renebrandel and others added 14 commits February 9, 2024 12:43

Update index.mdx (#6898)

420a008

* Update index.mdx * Update index.mdx

Preload analytics (#6891)

d4d0899

* Preload s_code * Use prefetch for analytics scripts * Try preload

Add context to explicitly add allowGuestAccess when using public ia…

523e847

…m provider with CDK construct (#6902) * Update index.mdx * possessive apos --------- Co-authored-by: Chris Bonifacio <christopher.bonifacio@gmail.com>

Edits to Next.js App Router (Server Components) quickstart (#6899)

8a88e96

fix storage upload (#6900)

30c587a

* fix storage upload docs

Fix tiny aws logo (#6903)

ff62f7c

* fix: size of AWS logo in footer and aria-label * remove aria-hidden on logo

fix: added WidgetsFlutterBinding.ensureInitialized(); before await _c…

094d58e

…onfigureAmplify(); (#6904) - fix: add WidgetsFlutterBinding.ensureInitialized(); before await _configureAmplify();

chore: add unit tests for Breadcrumbs

7a2446c

Merge branch 'breadcrumbs-type-error' into tests-breadcrumbs

dec60b1

testing to include platform optional

7c0d301

katiegoines dismissed hbuchel’s stale review via 7c0d301 February 15, 2024 13:50

katiegoines requested review from reesscot, srquinn21, Milan-Shah, swaminator, renebrandel, dbanksdesign, hdworld11 and josefaidt as code owners February 15, 2024 13:50

github-actions bot added deleted-assets Indicate that a PR has changes with deleted assets redirects-needed Redirects need to be created for deleted pages labels Feb 15, 2024

katiegoines added 2 commits February 15, 2024 05:55

fix: type platform as optional

bfff2ac

Merge branch 'tests-breadcrumbs' into breadcrumbs-type-error

03f8a13

katiegoines closed this Feb 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: type error for Breadcrumbs component #6813

fix: type error for Breadcrumbs component #6813

katiegoines commented Jan 22, 2024

mergify bot commented Feb 15, 2024

mergify bot commented Feb 15, 2024

fix: type error for Breadcrumbs component #6813

fix: type error for Breadcrumbs component #6813

Conversation

katiegoines commented Jan 22, 2024

Description of changes:

Related GitHub issue #, if available:

Instructions

Checks

When this PR is ready to merge, please check the box below

mergify bot commented Feb 15, 2024

mergify bot commented Feb 15, 2024