Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-release/main): update home page h1 and code block font size #7117

Merged
merged 6 commits into from
Mar 26, 2024
Merged

fix(next-release/main): update home page h1 and code block font size #7117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36e0fa3
update font sizes
hbuchel Mar 25, 2024
a0ced57
add text-size-adjust
hbuchel Mar 25, 2024
5a75571
add webkit prefix, add comment
hbuchel Mar 25, 2024
47b9627
update text-size-adjust fix
hbuchel Mar 26, 2024
d97e634
Merge branch 'next-release/main' into FixFontSizes
timngyn Mar 26, 2024
b05e46c
Merge branch 'next-release/main' into FixFontSizes
timngyn Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/styles/code.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ code:not([class]) {
margin: var(--amplify-space-xs) 0;
padding-block: var(--amplify-space-xs);
font-size: var(--amplify-font-sizes-medium);
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would put the un-prefixed property last (with the expectation browsers that don't yet support it would just ignore it), but when testing on iOS it wasn't picking up the vendor prefixed version and the un-prefixed version wasn't working. 🤔 Reversing them fixes it.

Safari on iOS requires the webkit prefix for text-size-adjust.
text-size-adjust fixes some fonts from showing larger than normal in some browsers.
*/
text-size-adjust: 100%;
-webkit-text-size-adjust: 100%;

&:focus-visible {
outline: none;
box-shadow: 0 0 0 2px var(--amplify-colors-white) inset;
Expand Down
5 changes: 5 additions & 0 deletions src/styles/home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
z-index: 1;
&__heading {
font-family: var(--font-code);
font-size: var(--amplify-font-sizes-xxxl);
text-wrap: pretty;
@media (min-width: $mq-mobile) {
font-size: var(--amplify-components-heading-1-font-size);
}
}
&__text {
max-width: 580px;
Expand Down
Loading