-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend code generator set
functionality/directive
#464
Extend code generator set
functionality/directive
#464
Conversation
Skipping CI for Draft Pull Request. |
/retest |
/test all |
/test dynamodb-controller-test |
1 similar comment
/test dynamodb-controller-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Vandita2020 - looks like this PR have some changes that we reviewd in #462 . Can you please delete the first 4 commits in this branch?
/hold
50067ec
to
4b27e88
Compare
/test s3-controller-test |
/test ec2-controller-test |
/test all |
/retest all |
@a-hilaly: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/retest |
/test all |
1 similar comment
/test all |
/retest |
c21a212
to
c12a3d4
Compare
/test s3-olm-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff~
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
ignore
workignore
directive functionality
ignore
directive functionality set
functionality/directive
Issue
This PR is related to fix the issue generating after executing PR #462
Summary
The PR helps in disregarding fields marked with
set: ignore
for nested fields. It also enhances the functionality ofset:ignore
to support the exclusion of fields fromset_sdk
.Description
The PR fixes the issue coming after a new custom field is created and has
set.ignore
set totrue
for it. Even after setting the field to ignore, the field is getting used to set the SDK fields. In this case particularly, the new field was defined as shown below:And the issue it is causing is under
sdk.go/newCreateRequestPayload
function, where it is being set, as shown below:The goal is to ignore this particular line of code. And also to improve the basic functionality of
set.ignore
.The
set.ignore
functionality was till now supporting exclusion of fields only when the field was used to set for the resource. This is when theset.from
is also given, theset.from
ignores the field coming from the resource. However whenset.to
is used, which is to ignore the field while setting SDK fields, the ignore didn't support that. This functionality got left behind because theset.to
was added afterwards.This PR added new way to set
ignore
. Theignore
field can be set tofrom
,to
orall
depending on whether you want to ignore setting the field for resource, or ignore the field for sdk, or for both, respectively.So the above code will now look like:
Limitations
Currently this PR checks the
set.ignore
field only for members of the field whose type isstructure
.Acknowledgment
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.