Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Route table #6

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Adding Route table #6

merged 6 commits into from
Sep 8, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Sep 3, 2021

Issue #, if available: #489

Description of changes:

  • adds route table resource
  • refactors e2e tests to share common resources (i.e. VPC)
    • otherwise, vpcs would need to be created for each test which is inefficient and may exceed quota
    • now, only 2 vpcs are created per test run
    • could not use @pytest.fixture(scope="session") on vpc because we use pytest-xdist
  • adds route table tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta
Copy link
Contributor Author

brycahta commented Sep 3, 2021

/cc @vijtrip2

@brycahta
Copy link
Contributor Author

brycahta commented Sep 3, 2021

/assign @RedbackThomson

test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/conftest.py Outdated Show resolved Hide resolved
Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward! No custom logic? Impressive.

Left some comments in your tests.

test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_subnet.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

test/e2e/tests/test_route_table.py Show resolved Hide resolved
test/e2e/tests/test_route_table.py Outdated Show resolved Hide resolved
test/e2e/tests/test_subnet.py Outdated Show resolved Hide resolved
test/e2e/tests/test_subnet.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jaypipes
Copy link
Contributor

jaypipes commented Sep 8, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit aba499a into aws-controllers-k8s:main Sep 8, 2021
@brycahta brycahta deleted the route-table branch September 8, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants