Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.26.0, code-generator v0.26.1 #69

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented May 15, 2023

Update to ACK runtime v0.26.0, code-generator v0.26.1



NOTE:
This PR increments the release version of service controller from v1.0.2 to v1.0.3

Once this PR is merged, release v1.0.3 will be automatically created for eks-controller

Please close this PR, if you do not want the new patch release for eks-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building eks-controller ====
Copying common custom resource definitions into eks
Building Kubernetes API objects for eks
Generating deepcopy code for eks
Generating custom resource definitions for eks
Building service controller for eks
Generating RBAC manifests for eks
Running gofmt against generated code for eks
Updating additional GitHub repository maintenance files
==== building eks-controller release artifacts ====
Building release artifacts for eks-v1.0.3
Generating common custom resource definitions
Generating custom resource definitions for eks
Generating RBAC manifests for eks

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jljaco
Copy link
Contributor

jljaco commented May 16, 2023

/retest

@ack-prow
Copy link

ack-prow bot commented May 18, 2023

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-codespell a9854e3 link true /test eks-codespell

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RedbackThomson RedbackThomson force-pushed the ack-bot/rt-v0.26.0-codegen-v0.26.1 branch from a9854e3 to 27483cf Compare June 12, 2023 19:55
@RedbackThomson
Copy link
Contributor

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants