Enhance namespace validation and retrieval for controller scope #132
Conversation
This patch introduces validation for user-provided namespaces, ensuring RFC 1123 compliance and validiy for defining the controller's scope. The ACK controllers will now validate the comma-seperated list of namespaces and expose a method for quering and reusing these validate namespaces. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
|
/cc @acornett21 |
|
@a-hilaly: GitHub didn't allow me to request PR reviews from the following users: acornett21. Note that only aws-controllers-k8s members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot, acornett21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…controllers-k8s#132) This patch introduces validation for user-provided namespaces, ensuring RFC 1123 compliance and validiy for defining the controller's scope. The ACK controllers will now validate the comma-seperated list of namespaces and expose a method for quering and reusing these validate namespaces. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…controllers-k8s#132) This patch introduces validation for user-provided namespaces, ensuring RFC 1123 compliance and validiy for defining the controller's scope. The ACK controllers will now validate the comma-seperated list of namespaces and expose a method for quering and reusing these validate namespaces. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This patch introduces validation for user-provided namespaces, ensuring
RFC 1123 compliance and validiy for defining the controller's scope. The
ACK controllers will now validate the comma-seperated list of namespaces
and expose a method for quering and reusing these validate namespaces.
Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.