-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runtime dependencies and toolchain #150
Merged
ack-prow
merged 1 commit into
aws-controllers-k8s:main
from
a-hilaly:controller-runtime-v0.18
Jul 12, 2024
Merged
Update runtime dependencies and toolchain #150
ack-prow
merged 1 commit into
aws-controllers-k8s:main
from
a-hilaly:controller-runtime-v0.18
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
changed the title
Update dependencies and toolchain
Update runtime dependencies and toolchain
Jun 19, 2024
/lgtm |
TiberiuGC
approved these changes
Jul 11, 2024
/retest |
2 similar comments
/retest |
/retest |
This commit updates several Go module dependencies to their latest versions: - Update to Go 1.22.5 runtime and 1.22.3 toolchain - Update k8s.io dependencies to v0.30.1 (from v0.29.0) - `k8s.io/api` - `k8s.io/apimachinery` - `k8s.io/client-go` - `k8s.io/apiextensions-apiserver` - Update `controller-runtime` to v0.18.4 (from v0.17.2) - Update `klog` to v2.120.1 (from v2.110.1) it also adds a fake `AddMetricsServerExtraHandler` method to the fakeManager in the unit tests to satisfy the updated AWSResourceManager interface
a-hilaly
force-pushed
the
controller-runtime-v0.18
branch
from
July 12, 2024 07:18
d3296d1
to
4e65da9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates several Go module dependencies to their latest versions:
k8s.io/api
k8s.io/apimachinery
k8s.io/client-go
k8s.io/apiextensions-apiserver
controller-runtime
to v0.18.2 (from v0.17.2)klog
to v2.120.1 (from v2.110.1)it also adds a fake
AddMetricsServerExtraHandler
method to thefakeManager in the unit tests to satisfy the updated
ctrlruntime.Manager
interface
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.