Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime dependencies and toolchain #150

Merged

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Jun 19, 2024

This commit updates several Go module dependencies to their latest versions:

  • Update to Go 1.22.5 runtime and 1.22.3 toolchain
  • Update k8s.io dependencies to v0.30.0 (from v0.29.0)
  • k8s.io/api
  • k8s.io/apimachinery
  • k8s.io/client-go
  • k8s.io/apiextensions-apiserver
  • Update controller-runtime to v0.18.2 (from v0.17.2)
  • Update klog to v2.120.1 (from v2.110.1)

it also adds a fake AddMetricsServerExtraHandler method to the
fakeManager in the unit tests to satisfy the updated ctrlruntime.Manager
interface

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and jljaco June 19, 2024 01:13
@ack-prow ack-prow bot added the approved label Jun 19, 2024
@a-hilaly a-hilaly changed the title Update dependencies and toolchain Update runtime dependencies and toolchain Jun 19, 2024
@TiberiuGC
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 12, 2024

/retest

2 similar comments
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 12, 2024

/retest

@a-hilaly
Copy link
Member Author

/retest

This commit updates several Go module dependencies to their latest versions:

- Update to Go 1.22.5 runtime and 1.22.3 toolchain
- Update k8s.io dependencies to v0.30.1 (from v0.29.0)
 - `k8s.io/api`
 - `k8s.io/apimachinery`
 - `k8s.io/client-go`
 - `k8s.io/apiextensions-apiserver`
- Update `controller-runtime` to v0.18.4 (from v0.17.2)
- Update `klog` to v2.120.1 (from v2.110.1)

it also adds a fake `AddMetricsServerExtraHandler` method to the
fakeManager in the unit tests to satisfy the updated AWSResourceManager
interface
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 12, 2024

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
Copy link

ack-prow bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot, TiberiuGC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit ebeff35 into aws-controllers-k8s:main Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants