Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NewTerminalError method to be not instance method #83

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

nmvk
Copy link
Member

@nmvk nmvk commented Apr 5, 2022

Cannot instantiate without this change.

Cannot instantiate without this change
@RedbackThomson RedbackThomson changed the title Update New method to be not instance method Update NewTerminalError method to be not instance method Apr 5, 2022
@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Apr 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmvk, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 2e1aaae into aws-controllers-k8s:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants