Skip to content

Commit befe030

Browse files
committed
change app resource name
1 parent f7d72c8 commit befe030

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

test/e2e/resources/app_space.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
apiVersion: sagemaker.services.k8s.aws/v1alpha1
22
kind: App
33
metadata:
4-
name: default
4+
name: $APP_NAME
55
spec:
66
domainID: $DOMAIN_ID
77
spaceName: $SPACE_NAME
8-
appName: default
8+
appName: $APP_NAME
99
appType: JupyterServer
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
apiVersion: sagemaker.services.k8s.aws/v1alpha1
22
kind: App
33
metadata:
4-
name: default
4+
name: $APP_NAME
55
spec:
66
domainID: $DOMAIN_ID
77
userProfileName: $USER_PROFILE_NAME
8-
appName: default
8+
appName: $APP_NAME
99
appType: JupyterServer

test/e2e/tests/test_studio.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,17 +133,18 @@ def apply_space_yaml(domain_id, user_profile_name, resource_name, share_type):
133133
return reference, resource, spec
134134

135135

136-
def apply_app_yaml(domain_id, app_association, resource_name):
136+
def apply_app_yaml(domain_id,app_association, app_association_resource_name, resource_name):
137137
app_association = app_association.lower()
138138
assert app_association in ["user_profile", "space"]
139139

140140
replacements = REPLACEMENT_VALUES.copy()
141141
replacements["DOMAIN_ID"] = domain_id
142+
replacements["APP_NAME"] = resource_name
142143
if app_association == "user_profile":
143-
replacements["USER_PROFILE_NAME"] = resource_name
144+
replacements["USER_PROFILE_NAME"] = app_association_resource_name
144145

145146
elif app_association == "space":
146-
replacements["SPACE_NAME"] = resource_name
147+
replacements["SPACE_NAME"] = app_association_resource_name
147148

148149
reference, spec, resource = create_sagemaker_resource(
149150
resource_plural="apps",

0 commit comments

Comments
 (0)