Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove IDT tag from multiplatform component feature tests #238

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

aws-kevinrickard
Copy link
Member

Issue #, if available:
P123929293

Description of changes:
Disable multi-platform component feature tests when running in IDT

Why is this change necessary:
These tests are not necessary for IDT

How was this change tested:
n/a

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Apr 2, 2024

Unit Tests Coverage Report for aws-greengrass-testing-features

File Coverage Lines Branches
All files 30% 37% 23%
com.aws.greengrass.testing.model.TestContextModel 0% 0% 0%
com.aws.greengrass.testing.model.RegistrationContextModel 0% 0% 0%
com.aws.greengrass.testing.model.ScenarioContext 64% 70% 57%
com.aws.greengrass.testing.model.GreengrassContextModel 25% 25% 0%
com.aws.greengrass.testing.component.RecipeComponentPreparationService$1 100% 100% 0%
com.aws.greengrass.testing.component.LocalComponentPreparationService$1 100% 100% 0%
com.aws.greengrass.testing.component.ClasspathComponentPreparationService 100% 100% 0%
com.aws.greengrass.testing.component.CloudComponentPreparationService 32% 39% 25%
com.aws.greengrass.testing.component.FileComponentPreparationService 100% 100% 0%
com.aws.greengrass.testing.component.CompositeComponentPreparationService 100% 100% 0%
com.aws.greengrass.testing.component.PreparationServiceUtils 10% 10% 0%
com.aws.greengrass.testing.component.LocalComponentPreparationService 59% 56% 63%
com.aws.greengrass.testing.component.RecipeComponentPreparationService 48% 53% 44%
com.aws.greengrass.testing.util.EncryptionUtils 0% 0% 0%
com.aws.greengrass.testing.util.EncryptionUtils$PemWriter 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps 26% 38% 13%
com.aws.greengrass.testing.features.GreengrassSteps 100% 100% 0%
com.aws.greengrass.testing.features.FileSteps$ByteNotation 0% 0% 0%
com.aws.greengrass.testing.features.FileSteps 11% 11% 0%
com.aws.greengrass.testing.features.WaitSteps 55% 73% 38%
com.aws.greengrass.testing.features.IamSteps 0% 0% 0%
com.aws.greengrass.testing.features.IotSteps 44% 44% 0%
com.aws.greengrass.testing.features.AWSResourcesSteps 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps$2 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps$1 100% 100% 0%
com.aws.greengrass.testing.features.NetworkUtilsSteps 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps$3 100% 100% 0%
com.aws.greengrass.testing.features.S3Steps 72% 94% 50%
com.aws.greengrass.testing.features.RegistrationSteps 34% 40% 28%
com.aws.greengrass.testing.features.GreengrassCliSteps 36% 54% 17%
com.aws.greengrass.testing.features.LoggerSteps 0% 0% 0%
com.aws.greengrass.testing.features.SystemMetricSteps 0% 0% 0%
com.aws.greengrass.testing.DefaultGreengrass 54% 69% 38%
com.aws.greengrass.testing.modules.HsmParameters 0% 0% 0%
com.aws.greengrass.testing.modules.FeatureParameters 0% 0% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 1385d3f

Copy link

github-actions bot commented Apr 2, 2024

Unit Tests Coverage Report for aws-greengrass-testing-launcher

File Coverage Lines Branches
All files 65% 76% 53%
com.aws.greengrass.testing.launcher.reporting.StepTrackingReporting 49% 62% 36%
com.aws.greengrass.testing.launcher.utils.CucumberReportUtils 95% 100% 90%
com.aws.greengrass.testing.launcher.ParallelizationConfig 100% 100% 0%
com.aws.greengrass.testing.launcher.TestLauncherParameterValues 0% 0% 0%
com.aws.greengrass.testing.launcher.TestLauncherParameters 100% 100% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 1385d3f

Copy link

github-actions bot commented Apr 2, 2024

Unit Tests Coverage Report for aws-greengrass-testing-platform-api

File Coverage Lines Branches
All files 40% 30% 49%
com.aws.greengrass.testing.platform.windows.WindowsNetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.windows.WindowsPlatform 75% 75% 0%
com.aws.greengrass.testing.platform.windows.WindowsNetworkUtils$1 0% 0% 0%
com.aws.greengrass.testing.platform.windows.WindowsCommands 43% 36% 50%
com.aws.greengrass.testing.platform.macos.MacosNetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.macos.MacosCommands 96% 100% 92%
com.aws.greengrass.testing.platform.macos.MacosPlatform 75% 75% 0%
com.aws.greengrass.testing.platform.linux.LinuxNetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.linux.LinuxCommands 100% 100% 0%
com.aws.greengrass.testing.platform.linux.LinuxPlatform 75% 75% 0%
com.aws.greengrass.testing.platform.AbstractPlatform 100% 100% 0%
com.aws.greengrass.testing.platform.PlatformResolver 96% 100% 92%
com.aws.greengrass.testing.platform.RemoteFiles 15% 15% 0%
com.aws.greengrass.testing.platform.LocalFiles 61% 71% 50%
com.aws.greengrass.testing.platform.NetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.UnixPathsMixin 0% 0% 0%
com.aws.greengrass.testing.platform.UnixCommands 7% 7% 0%
com.aws.greengrass.testing.platform.DevicePredicatePlatformFiles 28% 28% 0%
com.aws.greengrass.testing.platform.NucleusInstallationParametersModel 0% 0% 0%
com.aws.greengrass.testing.platform.Commands 0% 0% 0%
com.aws.greengrass.testing.platform.PlatformFiles 0% 0% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 1385d3f

Copy link

github-actions bot commented Apr 2, 2024

Unit Tests Coverage Report for aws-greengrass-testing-platform-pillbox

File Coverage Lines Branches
All files 66% 67% 65%
com.aws.greengrass.testing.pillbox.commands.files.Exists 100% 100% 100%
com.aws.greengrass.testing.pillbox.commands.files.Mkdir 87% 90% 83%
com.aws.greengrass.testing.pillbox.commands.files.Find 82% 100% 64%
com.aws.greengrass.testing.pillbox.commands.files.Cat 100% 100% 100%
com.aws.greengrass.testing.pillbox.commands.files.Remove 88% 93% 83%
com.aws.greengrass.testing.pillbox.commands.files.Find$Type 89% 93% 86%
com.aws.greengrass.testing.pillbox.Pillbox 0% 0% 0%
com.aws.greengrass.testing.pillbox.commands.Process 0% 0% 0%
com.aws.greengrass.testing.pillbox.commands.Files 0% 0% 0%
com.aws.greengrass.testing.pillbox.commands.process.Descendants 0% 0% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 1385d3f

Copy link
Member

@MikeDombo MikeDombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging and building in, make sure that the IDT version has actually consumed this change properly. Look inside the zip/jar file if needed to validate the artifacts

@MikeDombo MikeDombo merged commit 7bd443b into main Apr 2, 2024
5 checks passed
@MikeDombo MikeDombo deleted the idt_multiplatform_fix branch April 2, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants