Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for Terraform v1.3+ using local version of partner modules temporarily #1037

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Oct 8, 2022

What does this PR do?

  • Add support for Terraform v1.3+ using local version of partner modules temporarily. Once the associated pull requests have been remediated on the external addon projects, we can remove the local versions added in this PR in favor of the external addons. An issue has been created to track this follow up update to use the external addons once remediated - but for now this unblocks users of EKS Blueprints

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 8, 2022 13:56 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 8, 2022 14:00 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 8, 2022 14:21 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 8, 2022 14:47 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 10, 2022 16:13 Inactive
@bryantbiggs bryantbiggs merged commit fd55f69 into main Oct 10, 2022
@bryantbiggs bryantbiggs deleted the fix/terraform-v1.3-support branch October 10, 2022 16:47
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants