Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace EFS standalone resources with EFS module #1081

Merged
merged 1 commit into from
Oct 24, 2022
Merged

chore: Replace EFS standalone resources with EFS module #1081

merged 1 commit into from
Oct 24, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Replace EFS standalone resources with EFS module

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 24, 2022 20:17 Inactive
Zvikan
Zvikan reviewed Oct 24, 2022
View reviewed changes
examples/stateful/main.tf
@@ -216,3 +209,16 @@ resource "kubernetes_storage_class" "storage_class" {
type = "gp3"
}
}

resource "kubernetes_storage_class_v1" "efs" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what's the reason we need this now ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like we didn't fill out the example completely/thoroughly (and there is still plenty of room for improvements) but we have the EFS CSI addon enabled but we never demonstrated how it maps to the StorageClass like we do between the EBS CSI driver and its associated StorageClass resource. So this just demonstrates one way of consuming the EFS system using the dynamic provisioner method

tl;dr - do we need it - the addon can be enabled without it but users wouldn't be able to utilize an EFS file share (sort of like creating a cluster without a data plane - you can, it just isn't very useful nor how its usually used)

Zvikan
Zvikan approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have 1 knowledge question regards kubernetes_storage_class_v1. Thank you!

@bryantbiggs bryantbiggs merged commit 801ebe8 into main Oct 24, 2022
@bryantbiggs bryantbiggs deleted the refactor/efs-module branch October 24, 2022 20:50
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
@bryantbiggs @vara-bonthu
chore: Replace EFS standalone resources with EFS module (#1081)
2175e79
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@bryantbiggs @allamand
chore: Replace EFS standalone resources with EFS module (aws-ia#1081)
62563c3
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@bryantbiggs @allamand
chore: Replace EFS standalone resources with EFS module (aws-ia#1081)
8ea1f5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zvikan Zvikan Zvikan approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@csantanapr csantanapr Awaiting requested review from csantanapr

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace EFS resources with EFS module
2 participants
@bryantbiggs @Zvikan